Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Helm 3 #184

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Add support for Helm 3 #184

merged 1 commit into from
Nov 28, 2019

Conversation

unguiculus
Copy link
Member

No description provided.

@helm-bot helm-bot added the size/L label Nov 3, 2019
@unguiculus unguiculus force-pushed the helm3-support branch 2 times, most recently from 8d168c3 to e109224 Compare November 3, 2019 17:35
@unguiculus
Add support for Helm 3
d8ef6f1 
Signed-off-by: Reinhard Naegele <[email protected]>
@unguiculus unguiculus marked this pull request as ready for review November 19, 2019 15:16
@naseemkullah
Copy link
Contributor

bump

scottrigby
scottrigby approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm! 💯

@scottrigby
Copy link
Member

Note I have not yet had a chance to test this. If others get a chance to test it first, that would be great 😄

@unguiculus unguiculus merged commit b857274 into helm:master Nov 28, 2019
@unguiculus unguiculus deleted the helm3-support branch November 28, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottrigby scottrigby scottrigby approved these changes

@jlegrone jlegrone Awaiting requested review from jlegrone

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@unguiculus @naseemkullah @scottrigby @helm-bot